Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][doc] Fixes example code in Cluster Failover Java Client #891

Merged
merged 1 commit into from
Apr 28, 2024
Merged

[fix][doc] Fixes example code in Cluster Failover Java Client #891

merged 1 commit into from
Apr 28, 2024

Conversation

sandeep-mst
Copy link
Contributor

@sandeep-mst sandeep-mst commented Apr 26, 2024 •
edited
Loading

Cluster failover Java client is available for 2.10.0 and later versions.
This PR fixes example code shown in Automatic-failover and Controlled-failover

It adds required ServiceUrlProvider while building PulsarClient
.serviceUrlProvider(failover)

Controlled Failover

Automatic Failover

✅ Contribution Checklist

asafm
asafm approved these changes Apr 28, 2024
View reviewed changes
Copy link
Contributor

@asafm asafm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! I'm surprised it didn't contain that important line.

@visortelle visortelle merged commit c86ecf3 into apache:main Apr 28, 2024
2 checks passed
@sandeep-mst sandeep-mst deleted the cluster-failover-java-doc-fix branch September 4, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asafm asafm asafm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandeep-mst @asafm @visortelle